Skip to content

Updated deep_copy on Plan model to set feedback_requested to false - #2309

Merged
raycarrick-ed merged 1 commit into
developmentfrom
bug/feedback-copied-plan
Dec 11, 2019
Merged

Updated deep_copy on Plan model to set feedback_requested to false#2309
raycarrick-ed merged 1 commit into
developmentfrom
bug/feedback-copied-plan

Conversation

@briri

@briri briri commented Dec 9, 2019

Copy link
Copy Markdown
Contributor

Fixes #2180 .

Changes proposed in this PR:

  • If a feedback had been requested for a plan, and then someone copies the plan, the copy was retaining the feedback_requested flag. I have updated the deep_copy method on the Plan model so that it always sets this flag to false.
  • Added a test to Plan model's deep_copy method to check that feedback_requested is set to false

@raycarrick-ed raycarrick-ed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@raycarrick-ed
raycarrick-ed merged commit f99a19e into development Dec 11, 2019
@briri
briri deleted the bug/feedback-copied-plan branch December 16, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants