added method to reattach labels to their corresponding tinymce iframe - #2333
Merged
Conversation
raycarrick-ed
approved these changes
Dec 18, 2019
raycarrick-ed
left a comment
raycarrick-ed
left a comment
Contributor
There was a problem hiding this comment.
Checked on a number of different plans and all seemed to have the correct "for" attribute. So looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1449.
Changes proposed in this PR:
app/javascript/utils/tinymce.jsfile so that it reconnects labels to the Tinymce iframe after it has initialized.To test (without a screen reader), inspect the html on any page with Tinymce editors and look for the label (question text in the case of a plan's answers) and make sure that the
forattribute lists the id of the corresponding tinymce iframe element