Skip to content

made the user_edit_profile lang field default to DB default language - #2363

Merged
briri merged 1 commit into
DMPRoadmap:developmentfrom
DigitalCurationCentre:issue/2362
Jan 24, 2020
Merged

made the user_edit_profile lang field default to DB default language#2363
briri merged 1 commit into
DMPRoadmap:developmentfrom
DigitalCurationCentre:issue/2362

Conversation

@xsrust

@xsrust xsrust commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

see #2362 for details

@briri briri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @xsrust

@briri

briri commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Travis shows a failure above but when you click through its all passing. 🤷‍♂
Github workflows are happy so going to merge it

@briri
briri merged commit bd0f050 into DMPRoadmap:development Jan 24, 2020
@xsrust

xsrust commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

Yeah, the template_versioning_spec was throwing something on the funder-template-update not showing to an org-admin users (and only on PG-tests)
But I kicked it and it worked after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants