Commented out github workflow for rubocop - #2370
Merged
Merged
Conversation
xsrust
approved these changes
Jan 30, 2020
xsrust
left a comment
xsrust
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I completely missed this PR the last time I was reviewing.
Ray and I had kicked around the idea of running it over the codebase with the Rails 5 migration since we'll be in lots of the files anyway and have manual review of the site afterwards to check for any issues introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily commenting out the new Github Workflow for Rubocop.
We can re-enable once we've had a chance to do a full cleanup of the codebase using
rubicon -aand then manually cleaning up any stragglers.