fixed an inconsistency in the template counts for the usage dashboard - #2392
Merged
Conversation
Contributor
Author
|
Addresses #2083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some digging, it turned out the inconsistency was twofold.
First, when generating the statistics objects, we organise the templates by their
family_idbut we save the stats objects bytemplate.title. This means when both customized and non-customized versions of a template are used within an organisation, we save two separate counts, with the same name, ex:Then, when we're re-martialing the data for the plans_by_template chart, we iterate, identifying the different templates by name, and thus over-write the data with the last count.
It might be worthwile to adjust the way we save the statistics to differentiate between raw and customized funder templates, but for the meantime, I adjusted the template-chart helper to just add the counts when it encounters duplicate entries.