Conversation
Contributor
Author
|
NOTE: PR against master branch |
Contributor
Author
|
fixes to test-running from development for PG don't appear to be merged into Master yet, so that Action is expected to fail |
briri
approved these changes
Mar 4, 2020
briri
left a comment
briri
left a comment
Contributor
There was a problem hiding this comment.
nice refactor. Thanks for using the guard conditions, makes it much easier to read
Contributor
Author
|
merged in the github-workflow fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2415 and adds some wider test coverage.
See ticket for details of what was going wrong before