hackathon bug fixes - #2537
Merged
Merged
Conversation
xsrust
approved these changes
Jun 4, 2020
xsrust
left a comment
xsrust
left a comment
Contributor
There was a problem hiding this comment.
Thanks for pulling together those fixes
Comment on lines
+15
to
+22
| json.distribution [plan] do |distribution| | ||
| json.title "PDF - #{distribution.title}" | ||
| json.data_access "open" | ||
| json.download_url plan_export_url(distribution, format: :pdf) | ||
| json.format do | ||
| json.array! ["application/pdf"] | ||
| end | ||
| end |
| email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name } | ||
| user_name = User.find_by(email: @resource.email).nil? ? @resource.email : User.find_by(email: @resource.email).name(false) | ||
| inviter_name = @resource.is_a?(User) ? @resource.invited_by.name(false) : @resource.invited_by.name | ||
| inviter_name = @resource.invited_by.name |
Contributor
There was a problem hiding this comment.
In the case of accounts generated by API clients, what name gets put for the inviter_name or invited_by record?
Contributor
Author
There was a problem hiding this comment.
hmm. would be the name of the system api_clients.name. Maybe we should add a separate field for them that store a suitable name or a message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ type: "other", identifier: "12345" })rolesinstead ofrolegrant_iddistributionto thedatasetin the JSON output that contains thedownload_urlwhich points to the plans pdf export url