Issue/2158 - #2557
Merged
Merged
Conversation
…ling tests but github's going to need to be my sounding-board for fixing those as my dev-env refuses to run those)
briri
requested changes
Jun 10, 2020
briri
left a comment
briri
left a comment
Contributor
There was a problem hiding this comment.
Looks good @xsrust. Thanks for cleaning up rubocop and for adding those tests.
It looks like the schema.rb was rebuilt prior to rebase with the development branch though. It removes the conditions table. Once that's been updated feel free to merge yourself 👍
briri
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
filteredboolean to allStatobjects, defaulting to false.Adds a
stats_filterscope toPlanto define the filter logicExtends each service to generate both a filtered and unfiltered stat for each month
Adds a
excluding test planscheckbox to the usage-stats page to toggle the filtered and unfiltered stats.Propogates the
filteredstatus of the usage-dashboard through to all downloads on that page.