Skip to content

Rails5 fixes - #2702

Merged
briri merged 13 commits into
developmentfrom
rails5-fixes
Oct 7, 2020
Merged

Rails5 fixes#2702
briri merged 13 commits into
developmentfrom
rails5-fixes

Conversation

@briri

@briri briri commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Tweak to a class on the Edit Profile page
  • Fixed typo on the contributors page 'Principle' -> 'Principal'
  • New v3.rake file (the upgrade.rake file is getting really long) that contains:
    • Task to set nil orgs.language_id and users.language_id to the default language (creates an 'en-GB' one if not defined)
    • Task to set the nil orgs.feedback_email_subject and orgs.feedback_email_msg to the ones defined in the FeedbacksHelper.rb
briri added 13 commits October 2, 2020 09:48
@briri
fix bug with saving org profile changes when shib ds is enabled
21708fe
@briri
fix issue with togglizePasswords on create account form
59a7cb3
@briri
removed useless translation of empty string
b1602a4
@briri
updated test to mimic actual form params sent to controller
ede130e
@briri
updated params on orgs_controller test
7993f60
@briri
Merge branch 'development' into org-fix
3438bdc
@briri
updated params on orgs_controller test
4c6ceaa
@briri
Merge branch 'org-fix' of https://github.com/DMPRoadmap/roadmap into …
64f8328 
…org-fix
@briri
added new v3.rake for upgrade scripts (the old upgrade.rake was geeti…
1d6d30a 
…ng too big)
@briri
Merge branch 'development' into rails5-fixes
14240e8
@briri
fix issue with placement of 'active' class on edit profile tabs
aec4894
@briri
added task to set default feedback fields on orgs
3ec0f0d
@briri
fixed typo on contributors page
102a741
xsrust
xsrust approved these changes Oct 7, 2020
View reviewed changes

@xsrust xsrust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great,
Thanks for making a new upgrade rake:task file.
It's probably a good convention for us to atleast do that every time we release a major version.
@briri
briri merged commit a3b6742 into development Oct 7, 2020
@briri
briri deleted the rails5-fixes branch October 7, 2020 16:36
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
@briri
Merge pull request DMPRoadmap#2702 from DMPRoadmap/rails5-fixes
32ae34e 
Rails5 fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@briri @xsrust