Skip to content

Minor fixes for Rails 5 - #2703

Merged
xsrust merged 4 commits into
developmentfrom
minor-fixes
Oct 9, 2020
Merged

Minor fixes for Rails 5#2703
xsrust merged 4 commits into
developmentfrom
minor-fixes

Conversation

@briri

@briri briri commented Oct 8, 2020

Copy link
Copy Markdown
Contributor
  • Fixed an issue with the request feedback screen that was happening if the the feedback message contained the %{organisation_email} placeholder. That variable is in the default message from the feedbacks_helper.rb.
  • Updated the example credentials file
  • Updated the URL to the API documentation on the Edit Profile page
  • Fixed issue with api client emailer
@briri

briri commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

not sure why this one mysql test is failing. I restarted a few times but it keeps failing on the answer save message.

<p><%= _("Click below to give data management staff at #{plan.owner.org.name}, the Plan Owner's org, access to read and comment on your plan.") %></p>
<div class="well well-sm">
<%= sanitize plan.owner.org.feedback_email_msg.to_s % { user_name: current_user.name(false), plan_name: plan.title } %>
<%= sanitize plan.owner.org.feedback_email_msg.to_s % { user_name: current_user.name(false), plan_name: plan.title, organisation_email: current_user.org.contact_email } %>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, This adddresses #2694

@xsrust xsrust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @briri looks good

@xsrust
xsrust merged commit b3a305d into development Oct 9, 2020
@briri
briri deleted the minor-fixes branch December 18, 2020 17:00
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
* added organization_email back to feedback form message parser. Updated example credentials file

* updated url to API docs

* fix issue with api credentials email
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants