Rails 5/brakeman - #2713
Merged
Merged
Conversation
briri
approved these changes
Oct 27, 2020
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Rails 5/brakeman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves both of #2710 by ignoring the warnings.
These were previously ignored and after evaluation should be safe to continue to ignore, the warnings were thrown as the line-numbers had changed.
Additionally resolves the SQL injection warning from #2711 in
app/controllers/concerns/paginable.rbby converting from the string to symbol style of call chain.Note:
You can run
bundle exec brakeman -Ito run through the vulnerabilities locally with a dialogue to ignore them.See https://brakemanscanner.org/docs/ignoring_false_positives/ for more details