Skip to content

Fixes for remaining brakeman issues - #2714

Merged
xsrust merged 3 commits into
developmentfrom
fixes-brakeman
Nov 2, 2020
Merged

Fixes for remaining brakeman issues#2714
xsrust merged 3 commits into
developmentfrom
fixes-brakeman

Conversation

@briri

@briri briri commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Fixes #2711 and #2712

Changes proposed in this PR:

  • Fixed XSS vulnerability by moving link generation logic from the presenter (which required html_safe to be called) to a new helper file and using the Rails link_to helper
  • Addressed SQL Injection warning by moving table.field portion of query
  • Fixed an issue introduced with the fix for Fix redirect warnings #2710 that was causing the SQL query to fail because it was being passed the SortDirection class instead of the string direction. Fixedd by calling the class' to_s method
@xsrust
xsrust merged commit 9b08312 into development Nov 2, 2020
@briri
briri deleted the fixes-brakeman branch December 18, 2020 17:00
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
@briri
Fixes for remaining brakeman issues (DMPRoadmap#2714)
0e760fa 
* fixes for brakeman and paginable

* fix for rubocop

* fixed rspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@briri @xsrust