Template bug fix - #298
Merged
Merged
Conversation
vyruss
approved these changes
May 9, 2017
vyruss
left a comment
vyruss
left a comment
Contributor
There was a problem hiding this comment.
Looks fine & tested locally.
Contributor
|
The current migrations dont actually enforce a single published version for each set of dmptemplate_id. I've written a rake task to enforce this which will be in a future PR and added to the post-migration steps when it reaches the roadmap codebase. |
Contributor
|
Thanks @xsrust your rake task seems to work fine. |
Contributor
Author
|
Excellent. Thanks @xsrust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to the templates controller and the way it pulls in funder and org templates and an update to the email notification that gets sent out when a user changes sharing permissions.
This includes your shib/orcid PR from yesterday.
This change requires that each templates.dmptemplate_id only have one published version! I had to manually correct some of the records on our test instance, and you may need to do the same if you have not run the current DMPonline_v4 to DMPRoadmap migrations!