Skip to content

vyruss/bugfixes - #308

Merged
briri merged 7 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:vyruss/bugfixes
May 12, 2017
Merged

vyruss/bugfixes#308
briri merged 7 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:vyruss/bugfixes

Conversation

@vyruss

@vyruss vyruss commented May 12, 2017

Copy link
Copy Markdown
Contributor

(stuff in review column.)

@vyruss
vyruss requested a review from briri May 12, 2017 14:36

@briri briri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good @vyruss. Just one minor change. We shouldn't switch the error reporting on the production.rb file for the shared repo.

# Full error reports are disabled and caching is turned on.
config.consider_all_requests_local = false
config.consider_all_requests_local = true
config.action_controller.perform_caching = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't do this in the shared repo's file.

@briri
briri merged commit 0280a26 into DMPRoadmap:development May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants