DCC bug 697 - Fix for a roadmap-wide bug where the following were - #3119
Merged
briri merged 2 commits intoMar 3, 2022
Merged
Conversation
Contributor
Author
|
@briri & @raycarrick-ed I don't think Tests error are due to changes I made. |
failing in the REST API V1 call "GET 0/api/v1/plans" for following reasons: (1) Plans policy initialize method was broken (2) Each plan in the json array was using the email for the user name. DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/697 Changes made: (1) The initialize method in /policies/api/v1/plans super call requires no arguments, it was taking the ApiClient as an argument. (2) In /views/api/v1/contributors/_show.json.jbuilder we changed json.name as follows as we were previously using the 'User' rather than 'Contributor' object json.name contributor.is_a?(User) ? contributor.name(false) : contributor.name
johnpinto1
force-pushed
the
dcc_bug_697_api_v1_contact_displaying_email_for_name
branch
from
March 3, 2022 12:15
ef0f851 to
4ef7b22
Compare
Contributor
|
The tests are failing due to a dependency issue with the JS karma tests. I have commented the karma tests out in my PR, #3117. I think we should just eventually convert those over to feature RSpec tests since our strengths lie in the Ruby/Rails world instead of the JS world |
Contributor
Author
|
@briri & @raycarrick-ed I have added a commit that comments out the Karma tests as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failing in the REST API V1 call "GET 0/api/v1/plans"
for following reasons:
(1) Plans policy initialize method was broken
(2) Each plan in the json array was using the email for the user name.
Fix for DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/697
Changes made:
(1) The initialize method in /policies/api/v1/plans super call requires
no arguments, it was taking the ApiClient as an argument.
(2) In /views/api/v1/contributors/_show.json.jbuilder we changed
json.name as follows as we were previously using the 'User' rather than
'Contributor' object
json.name contributor.is_a?(User) ? contributor.name(false) : contributor.name