DCC Bug 698 - Fix for broken Template History functionality. - #3154
Merged
Conversation
DCC Issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/698 Changes: - added format: json and changed sort option to sort_field: 'templates.version', sort_direction: :desc to the paginable_renderise call in the history() method of paginable/templates_controller.
briri
approved these changes
Apr 13, 2022
briri
left a comment
briri
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Thanks @johnpinto1 for digging into this one!
It's amazing how much debugging and research one has to do with this paginable_renderise methods for such a small change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCC Issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/698
Changes:
format: json
and
changed sort option to
sort_field: 'templates.version', sort_direction: :desc
to the paginable_renderise call in the history() method of
paginable/templates_controller.
NOTE:
This fixes issue. But to see results you will need to change
which I have done
config.x.application.api_max_page_size = 5
to see
Otherwise with
config.x.application.api_max_page_size = 100
you see the same set of Templates for "View less" and "View all"