DCC bug 722 - Fix for dealing with situation where Rest API call - #3159
Merged
briri merged 2 commits intoApr 19, 2022
Conversation
"/api/v0/plans?page=ALL" was timing out because the processing was taking too long. Fix for bug https://github.com/DigitalCurationCentre/DMPonline-Service/issues/722 The following change seems to make a difference: - in /api/v0/plans_controller.rb the index() method replaced includes() with preload(): @plans = org_admin_plans.includes([{ roles: :user }, { answers: :question_options }, template: [{ phases: { sections: { questions: %i[question_format themes] } } }, :org]])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was timing out because the processing was taking too long.
Fix for bug https://github.com/DigitalCurationCentre/DMPonline-Service/issues/722
The following change seems to make a difference:
replaced includes() with preload():
@plans = org_admin_plans.includes([{ roles: :user }, { answers: :question_options },
template: [{ phases: {
sections: { questions: %i[question_format themes] }
} }, :org]])