Add array judgement for creators in text and csv download - #3167
Merged
Conversation
briri
approved these changes
May 2, 2022
briri
left a comment
briri
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pengyin-shan this looks like a great approach
Contributor
|
Looks like the change made Rubocop unhappy. I think it is fine to just add |
Contributor
Author
I see. Yeah, I also feel there's no easy way to get around it. I removed the corresponding check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
joinmethod was used to cause errors for@hash[:attribution]after it was changed to string. Add judgment in case some organizations want to include more than one creator.