Upgraded TinyMCE to V5 - #3169
Merged
Merged
Conversation
… download plans details coversheet is ticked by default. Fix for issue DMPRoadmap#3063. Changes: - added a configurable property to # Check download of a plan coversheet tickbox config.x.plans.download_coversheet_tickbox_checked = false - use property to check "project details coversheet" by default or not if property set. If property is unset, the tickbox is unchecked.
…gure_project_sheet_tickbox_for_plan_downloads Feature DMPRoadmap#3063 - Feature to be able to configure whether the download
add contributor to coversheet and add plan title to csv export
…ultiple_theme_help do not repeat help instructions for every guidance group
Contributor
|
Not sure why these 2 tests would be failing. The page doesn't even have a TinyMCE editor. Switching the target branch to rails_6 instead since this can be part of the larger upgrade and we will need to dig in and fix other tests anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded to the latest release of TinyMCE V5
(V6 just came out, it might be a bit soon)
Hopefully everything works !