Skip to content

add translation format for at_csv.rb and usage section - #3235

Merged
pengyin-shan merged 6 commits into
developmentfrom
add_translation
Nov 29, 2022
Merged

add translation format for at_csv.rb and usage section#3235
pengyin-shan merged 6 commits into
developmentfrom
add_translation

Conversation

@pengyin-shan

@pengyin-shan pengyin-shan commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

add translation format for csv headers and a few files in usage section

@pengyin-shan pengyin-shan changed the title add translation format for at_csv.rb Nov 15, 2022

@briri briri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @pengyin-shan

<p><%= _("Click below to give data management staff at #{plan.owner.org.name}, the Plan Owner's org, access to read and comment on your plan.") %></p>
<p>
<%=
_("Click below to give data management staff at %{owner_org}, the Plan Owner's org, access to read and comment on your plan.") % {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling that variable out of the string 👍🏻

@pengyin-shan
pengyin-shan merged commit cc4af48 into development Nov 29, 2022
@pengyin-shan
pengyin-shan deleted the add_translation branch November 29, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants