Skip to content

Froze mail gem version #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminfaure merged 13 commits into from
Jan 30, 2023
+8 −1
Merged

Froze mail gem version #3255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1feb31b
Froze mail gem version
benjaminfaure Dec 6, 2022
0320a29
Rubocoped Gemfile
benjaminfaure Dec 8, 2022
482f355
test CHANGELOG file
pengyin-shan Dec 6, 2022
eeab22e
update danger in gemfile
pengyin-shan Dec 6, 2022
2e761b5
add danger figuration
pengyin-shan Dec 6, 2022
e7231ab
fix rubocop
pengyin-shan Dec 6, 2022
f6a13bd
fix test folder name
pengyin-shan Dec 8, 2022
54797da
Updated CHANGELOG
benjaminfaure Dec 12, 2022
35bd57a
Merge branch 'development' into issue3254
benjaminfaure Dec 12, 2022
fe49376
Merge branch 'development' into issue3254
briri Dec 14, 2022
b9b21f6
Merge branch 'development' into issue3254
benjaminfaure Jan 24, 2023
9a62130
Merge branch 'development' into issue3254
benjaminfaure Jan 27, 2023
16f35a4
Merge branch 'development' into issue3254
benjaminfaure Jan 30, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Added popover for org profile page and added explanation for public plan
### Fixed

- Froze mail gem version [#3254](https://github.com/DMPRoadmap/roadmap/issues/3254)
- Updated the CSV export so that it now includes research outputs
- Updated sans-serif font used in PDF downloads to Roboto since Google API no longer offers Helvetica
- Fixed discrepencies with default/max per_page values for API and UI pagination
Expand Down
5 changes: 5 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ gem 'dotenv-rails'

gem 'activerecord_json_validator'

# We need to freeze the mail gem version as the recently released 2.8.0 triggers an exception
# We will need to check if it's fixed when we migrate to Ruby 3.0/3.1
# See : https://github.com/DMPRoadmap/roadmap/issues/3254
gem 'mail', '2.7.1'

# ================================= #
# ENVIRONMENT SPECIFIC DEPENDENCIES #
# ================================= #
Expand Down
3 changes: 2 additions & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,7 @@ DEPENDENCIES
kaminari
ledermann-rails-settings
listen
mail (= 2.7.1)
mimemagic
mocha
mysql2
Expand Down Expand Up @@ -624,4 +625,4 @@ RUBY VERSION
ruby 2.7.6p219

BUNDLED WITH
2.3.25
2.3.26