Added scss files to editorconfig - #3256
Merged
benjaminfaure merged 4 commits intoJan 24, 2023
Merged
Conversation
pengyin-shan
approved these changes
Dec 9, 2022
pengyin-shan
left a comment
pengyin-shan
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Don't know if there's any auto-correct tool to just fix our existing scss files?
briri
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to add scss files to the editorconfig file.
Should I review every scss files in the PR too ?