Fix for bug #3214 which had noted there was no request rate limit to - WIP - #3261
Merged
briri merged 5 commits intoMar 24, 2023
Merged
Conversation
johnpinto1
force-pushed
the
bug-3214-vulnerability_no_rate_limit_on_reset_password_link
branch
from
December 8, 2022 13:32
8497198 to
cbff267
Compare
johnpinto1
force-pushed
the
bug-3214-vulnerability_no_rate_limit_on_reset_password_link
branch
2 times, most recently
from
December 19, 2022 12:24
94ef895 to
d809377
Compare
resetting the password. The Rack-Attack middleware for blocking & throttling abusive requests is being used. https://github.com/rack/rack-attack/blob/6-stable/README.md Changes: - Added rack-attack version 6.6.1 gem. https://rubygems.org/gems/rack-attack/versions/6.6.1 - Added config/initializers/rack_attack.rb: - The rack-attack functionality is enabled with Rack::Attack.enabled = true but may be switched off Rack::Attack.enabled = false. - Password reset requests are currently throttled from from an IP address for POSTs to path /users/passwords and is limited 2 requests every 30 seconds. ess - Login requests are throttled from an IP address for POSTs to path /users/sign_in and is limited 4 requests every 30 seconds. - A new html page public/429.html with title "Too Many Request" is added.
johnpinto1
force-pushed
the
bug-3214-vulnerability_no_rate_limit_on_reset_password_link
branch
from
January 10, 2023 15:01
d809377 to
71c9e55
Compare
briri
changed the title
…on_reset_password_link
…on_reset_password_link
Contributor
|
@johnpinto1 I have rebased this against the latest development branch (which is now on Ruby 3.0.4). Did you want to make any further changes to this before it gets merged in? |
Contributor
Author
@briri go ahead and merge. |
briri
deleted the
bug-3214-vulnerability_no_rate_limit_on_reset_password_link
branch
March 24, 2023 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetting the password.
DO NOT MERGE: PR CREATED FOR DISCUSSION
The Rack-Attack middleware for blocking & throttling abusive requests is being used.
https://github.com/rack/rack-attack/blob/6-stable/README.md
Fixes #3214
Changes:
Rack::Attack.enabled = true
but may be switched off
Rack::Attack.enabled = false.