Skip to content

Fix KeywordArgs issue in Paginable concern #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminfaure merged 3 commits into from
Jan 27, 2023
Merged

Fix KeywordArgs issue in Paginable concern #3285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6734056
updated paginable concern to fix issue with keyword args
briri Jan 24, 2023
5246ce3
updated change log
briri Jan 24, 2023
223a7f9
Merge branch 'development' into fix-pagniable-links
benjaminfaure Jan 27, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Updated sans-serif font used in PDF downloads to Roboto since Google API no longer offers Helvetica
- Fixed discrepencies with default/max per_page values for API and UI pagination
- Updated JS that used to call the TinyMCE `setMode()` function so that it now calls `mode.set()` because the former is now deprecated.
- Fixed an issue with the Rails 6 keyword arguments change that was causing the `paginable_sort_link` to fail

### Changed

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/concerns/paginable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def sort_link_url(sort_field)
end
base_url = paginable_base_url(query_params[:page])
sort_url = URI(base_url)
sort_url.query = stringify_query_params(query_params)
sort_url.query = stringify_query_params(**query_params)
sort_url.to_s
"#{sort_url}&#{stringify_nonpagination_query_params}"
end
Expand Down