Skip to content

disable debugger check for rubocop >= 1.45.0 - #3292

Merged
briri merged 15 commits into
developmentfrom
issue3291
Mar 23, 2023
Merged

disable debugger check for rubocop >= 1.45.0#3292
briri merged 15 commits into
developmentfrom
issue3291

Conversation

@pengyin-shan

@pengyin-shan pengyin-shan commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Fixes #3291 and DMP Assisant reported common Github Action error: portagenetwork#319

Changes proposed in this PR:

I configure rubocop to disable debugging message checking because we have a lot of necessary messages that need to show in the terminal even if in the production environment.

@briri

briri commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Thanks for this @pengyin-shan. I actually think that's a useful check for files in the /app and /spec directories. Can you modify this PR so that it only excludes rake tasks?

Instead of 'Enabled: false' use:

Exclude:
    - 'lib/tasks/**/*'
@pengyin-shan

Copy link
Copy Markdown
Contributor Author

UPDATE on Feb 21, 2023: Github Action was forced to upgrade to node 18. Thus we see the same error as the DMP Assisant bug portagenetwork#319

I'll include setup-node Github action in this PR to assign a specific node version (16 will resolve this problem).

@pengyin-shan

Copy link
Copy Markdown
Contributor Author

Thanks for this @pengyin-shan. I actually think that's a useful check for files in the /app and /spec directories. Can you modify this PR so that it only excludes rake tasks?

Instead of 'Enabled: false' use:

Exclude:
    - 'lib/tasks/**/*'

Finally, all tests passed lol. I added exclusive to rubocop and updated Github actions to use node 16.

@benjaminfaure

Copy link
Copy Markdown
Contributor

@pengyin-shan you can solve this problem by adding NODE_OPTIONS=--openssl-legacy-provider to your environment

I ran into it recently when upgrading our config to Node 18

@pengyin-shan

Copy link
Copy Markdown
Contributor Author

@pengyin-shan you can solve this problem by adding NODE_OPTIONS=--openssl-legacy-provider to your environment

I ran into it recently when upgrading our config to Node 18

Unfortunately, I keep getting the --openssl-legacy-provider is not allowed in NODE_OPTIONS, I doubt it is because of Github action (I referred actions/setup-node#356 but it seems not to work). Currently, I'm going to assign the node 16 version so that our test can be passed.

@briri how do you feel about this?

@briri

briri commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

@pengyin-shan was correct, Github Actions would not allow the --openssl-legacy-provider to be set on NODE_OPTIONS. I reverted our actions to use node 16.6.0 for now in the main branch.

@briri
briri merged commit d8c121f into development Mar 23, 2023
@briri
briri deleted the issue3291 branch March 23, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants