Remove Auto-Generated TinyMCE Skins and Add public/tinymce/skins/ to .gitignore - #3466
Merged
Conversation
Generated by 🚫 Danger |
aaronskiba
force-pushed
the
tinymce-cleanup
branch
from
January 30, 2025 19:20
11c3936 to
d237cd4
Compare
These files are already being copied from `node_modules/` to `public/` whenever we run `rails s` (see `config/initializers/assets.rb`).
The `public/tinymce/skins/` directory and its contents are auto-generated whenever we run `rails s`.
aaronskiba
force-pushed
the
tinymce-cleanup
branch
from
April 25, 2025 15:21
3f581ec to
f1d57cd
Compare
aaronskiba
force-pushed
the
tinymce-cleanup
branch
from
April 25, 2025 15:47
0163272 to
4e75f32
Compare
johnpinto1
self-requested a review
April 25, 2025 15:51
johnpinto1
approved these changes
Apr 25, 2025
johnpinto1
left a comment
johnpinto1
left a comment
Contributor
There was a problem hiding this comment.
I really like this fix. I am surprised no one thought about it before. Those tinymce files removed created noise in codebase that one had to be careful to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
public/tinymce/skins/public/tinymce/skins/to.gitignore