Update all workflows to runs-on: ubuntu-24.04 and Consolidate Capybara Config - #3487
Merged
Conversation
- This change modifies the regex to capture the full versions for Ruby and Bundler.
The following error was being encountered in https://github.com/DMPRoadmap/roadmap/actions/runs/13907418160/job/38913596385?pr=3487: ``` Run actions/setup-ruby@v1 ------------------------ NOTE: This action is deprecated and is no longer maintained. Please, migrate to https://github.com/ruby/setup-ruby, which is being actively maintained. ------------------------ Error: Version 3.0.4 not found ```
aaronskiba
force-pushed
the
aaron/issues/3484
branch
from
March 17, 2025 18:53
71dc6c5 to
46389a1
Compare
- `imagemagick` is not pre-installed with `ubuntu-24.04`. However, it is required to resolve the following test failures:
```
Failures:
1) OrgsController PUT /org/admin/:id/admin_update succeeds for feedback changes
Failure/Error: return if logo.nil? || logo.height == 100
Dragonfly::Shell::CommandFailed:
Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-2x6nam.png, exit status: 127, error: sh: 1: identify: not found
# ./app/models/org.rb:357:in `resize_image'
# ./app/controllers/orgs_controller.rb:81:in `admin_update'
# ./spec/controllers/orgs_controller_spec.rb:60:in `block (3 levels) in <main>'
2) OrgsController PUT /org/admin/:id/admin_update updates the shibboleth entityID if super_admin and enabled
Failure/Error: return if logo.nil? || logo.height == 100
Dragonfly::Shell::CommandFailed:
Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-gp3t74.png, exit status: 127, error: sh: 1: identify: not found
# ./app/models/org.rb:357:in `resize_image'
# ./app/controllers/orgs_controller.rb:81:in `admin_update'
# ./spec/controllers/orgs_controller_spec.rb:73:in `block (3 levels) in <main>'
3) OrgsController PUT /org/admin/:id/admin_update succeeds
Failure/Error: return if logo.nil? || logo.height == 100
Dragonfly::Shell::CommandFailed:
Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-42hnxo.png, exit status: 127, error: sh: 1: identify: not found
# ./app/models/org.rb:357:in `resize_image'
# ./app/controllers/orgs_controller.rb:81:in `admin_update'
# ./spec/controllers/orgs_controller_spec.rb:43:in `block (3 levels) in <main>'
```
- Moved the `spec/rails_helper.rb` Capybara config to `spec/support/capybara.rb` - Rather than pasting the `Capybara.register_driver :headless_chrome` code, the extra `options.add_argument` code was added to `Capybara.register_driver :selenium_chrome_headless_custom`. - Renamed `:selenium_chrome_headless_add_window_size` to `:selenium_chrome_headless_custom`
johnpinto1
self-requested a review
March 25, 2025 16:02
johnpinto1
approved these changes
Mar 25, 2025
johnpinto1
left a comment
johnpinto1
left a comment
Contributor
There was a problem hiding this comment.
This looks like in does the job for the longer term. I use Linux Mint which uses 22.04, so I don't see any issues with this change locally.
johnpinto1
approved these changes
Mar 25, 2025
johnpinto1
left a comment
johnpinto1
left a comment
Contributor
There was a problem hiding this comment.
This looks like some of the changes I made to get the Selenium test to work in one f my PRs. So that is good. I will need to rebase that PR one we have a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3484
Changes proposed in this PR:
Updates from
runs-on: ubuntu-20.04toruns-on: ubuntu-24.04within all.github/workflowsfilesPrior to the
ubuntu-24.04update, all of the workflows were bumped toubuntu-22.04. The22.04update resulted in the Danger GitHub Action failing with the following output:actions/setup-ruby@v1has been replaced withruby/setup-ruby@v1. Additionally, the regex has been modified to capture the full Ruby and Bundler versions.Bumping the Postgres workflow from
runs-on: ubuntu-22.04toruns-on: ubuntu-22.04required the following extra steps:imagemagickis required for some of the tests but is not packaged withubuntu-24.04by default/featurestests: https://github.com/DMPRoadmap/roadmap/actions/runs/14041753874/job/39313346863