Fix :creator & :commenter traits in plans factory - #3526
Draft
aaronskiba wants to merge 3 commits into
Draft
Conversation
…eds-file Updated seeds.rb file for identifier_schemes to include context value and removed logo_url and identifier_prefix for Shibboleth (as it was causing issues with SSO). It passes the Rspec tests. Co-authored-by: dstuckey-uoe dstuckey@ed.ac.uk
- Prior to this change, rather than assigning the desired role to the newly created plan, executing `create(:plan, :creator...` or `create(:plan, :commenter...` would create a second new plan. - This code change makes sure that when the `creator` or `commenter` trait is specified, it is applied to the first created plan and a second one is not created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
create(:plan, :creator...orcreate(:plan, :commenter...would create a second new plan.creatororcommentertrait is specified, it is applied to the first created plan and that a second one is not created.