Using data-toggle attribute to initiliase and trigger any popover. - #453
Merged
Merged
Conversation
briri
reviewed
Jun 23, 2017
| }); | ||
| $('.has-tooltip').tooltip({ placement: "right", trigger: "focus" }); | ||
| $(".help").popover(); | ||
| //Initiliases all popovers on a page |
Contributor
There was a problem hiding this comment.
looks good @jollopre we'll have to remember to choose this one and remove mine when we merge over the CDL-MVP branch. I solved it in a similar way but used $("a[rel='popover']). Yours is better since it doesn't force the use of an anchor
Contributor
Author
There was a problem hiding this comment.
I noticed today when refactoring admin.js that there were multiple classes to trigger the same behaviour. That's the example provided in bootstrap website. Your example is good too but using data-* does not tight to a specific html tag.
vyruss
approved these changes
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#431