Skip to content

Xsrust/bugfixes - #465

Merged
vyruss merged 6 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:xsrust/bugfixes
Jun 27, 2017
Merged

Xsrust/bugfixes#465
vyruss merged 6 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:xsrust/bugfixes

Conversation

@xsrust

@xsrust xsrust commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Adds options for bullets to be square, disk, or circle in TinyMCE editor. Only Square and circle export to docx due to limitations in the htmltoword gem we are using for this functionality.

Updated Questions controller to properly deal with annotations being updated and assign org to guidance.

@xsrust

xsrust commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

Now addresses #463, allowing customizer's sections to optionally appear before the template creator's sections.

@vyruss
vyruss self-requested a review June 27, 2017 12:53
@vyruss
vyruss merged commit 12ef735 into DMPRoadmap:development Jun 27, 2017
@briri

briri commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

We should probably add some tooltips or text somewhere on the page that explains how the customizer's ability to now select a position of zero works. I'm not sure that it would be intuitive. We should also explain that whatever other position they select will always appear after the funder sections

@xsrust

xsrust commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

There were complaints from org-admins that when they set their section to 1, it would not always appear first. By allowing the customizer to select 0, they will see their section first.

As changing this number re-orders the sections in the org-admin interface(and saving refreshes page), I'm not sure how much explanation will be needed, but tooltips could be helpful.

@briri

briri commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

I guess we can add instructions later on then if we start getting a lot of helpdesk questions. Its a small percentage of the user base so hopefully not a big deal

@xsrust

xsrust commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

That sounds reasonable to me.

@vyruss

vyruss commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

@briri @xsrust yes, customizers are a small number of people right now, and those who need reordering are even fewer. If we find that more people ask about this issue we can document it within that page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants