Skip to content

Xsrust/bugfixes - #489

Merged
vyruss merged 4 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:xsrust/bugfixes
Jul 5, 2017
Merged

Xsrust/bugfixes#489
vyruss merged 4 commits into
DMPRoadmap:developmentfrom
DigitalCurationCentre:xsrust/bugfixes

Conversation

@xsrust

@xsrust xsrust commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

Bugfix:

  • fixes generation of api token when a user is given api permissions through the org-admin interface
    Performance:
  • Remove selection of roles/plans from default scope for users
  • Remove 2 N+1 querry issues on plan edit pages (each generating ~100-200 queries)
  • Re-evaluated and updated indexes to reflect queries in the codebase
@vyruss
vyruss self-requested a review July 5, 2017 13:57
vyruss
vyruss approved these changes Jul 5, 2017
View reviewed changes

@vyruss vyruss left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This needs a db:migrate
Looks good. Should have greatly improved performance with new indices.
@vyruss
vyruss merged commit 156fc6f into DMPRoadmap:development Jul 5, 2017
@briri

briri commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

indexes for the win! Thanks for cleaning these up @xsrust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@xsrust @briri @vyruss