Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified jamp_hit.py in a way that is compatible (as far as I tested) with digger_hit when used with boldigger-cline. I did not test it with the GUI.
This version of jamp_hit.py assigns the best hit using the JAMP method applied to BIN as the lowest possible taxonomic level rather than species. So, while it doesn't explicitly check for multiple BINs, I don't know if that's really necessary in this implementation since a) at high similarities (≥98%) the results should all have the same BIN, and b) BIN is discarded from hits whose similarity is lower than 98%.