listhtlcs pagination #8166
Open
listhtlcs pagination #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
5 times, most recently
from
22ccf70 to
670a36a
Compare
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
from
670a36a to
c49ccbb
Compare
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
2 times, most recently
from
cc2e043 to
d59e2bc
Compare
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
4 times, most recently
from
c1be2c6 to
2f1c2b1
Compare
Otherwise it can get included in contrib/msggen/msggen/schema.json! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The last argument is a pointer, but we were handing `false`. Which, for terrible historic reasons, gets treated as NULL. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It makes the schema simpler, and indeed, expressable by GRPC. Changelog-Added: JSON-RPC: `wait` now has separate `invoices`, `forwards` and `sendpays` objects for each subsystem. Changelog-Deprecated: JSON-RPC: `wait` reply `details` object: use subsytem specific object instead. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're not going to increment one at a time for bulk deletion of htlcs when a channel closes. There could be millions of HTLCs! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This prepares us for doing listhtlcs pagination. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Note that documentation says invoice expiries can batch, but that's no longer true, so delete it. Usually, we miss a number because the change is too fast. This adds the wait interface, but it doesn't actually fire until the next commit, which wires it into the db code. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON-RPC: `wait` now supports the `htlcs` (`listhtlcs`) subsystem.
…cs). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
from
2f1c2b1 to
42f6fca
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON-RPC: `listhtlcs` has `created_index` and `updated_index` fields.
Changelog-Added: JSON-RPC: `listhtlcs` supports `index`, `start` and `end` parameters for pagination support. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/listhtlcs-pagination
branch
from
42f6fca to
c1baf6d
Compare
|
ACK c1baf6d |
cdecker
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long requested, adds wait/pagination support to listhtlcs.