Skip to content

[fix issues 840] Modify the "plugin\score" of the Image send type#853

Merged
fumiama merged 1 commit intoFloatTech:masterfrom
vatebur:PR_branch
Jan 25, 2024
Merged

[fix issues 840] Modify the "plugin\score" of the Image send type#853
fumiama merged 1 commit intoFloatTech:masterfrom
vatebur:PR_branch

Conversation

@vatebur
Copy link
Copy Markdown
Member

@vatebur vatebur commented Jan 18, 2024

Modify the "plugin\score" of the Image send type
���配shamrock,修改图片发送方式,把发送路径改成发送完整图片

Copy link
Copy Markdown
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应当保留file:///模式,判断返回值,失败后再用base64发。

@vatebur
Copy link
Copy Markdown
Member Author

vatebur commented Jan 18, 2024

应当保留file:///模式,判断返回值,失败后再用base64发。

感谢建议,我再改改。

@vatebur vatebur force-pushed the PR_branch branch 2 times, most recently from 990bb98 to 6845d80 Compare January 19, 2024 06:07
@vatebur
Copy link
Copy Markdown
Member Author

vatebur commented Jan 19, 2024

改好了

Copy link
Copy Markdown
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有这四个处理都相同,考虑将它们封装为一个函数。

Copy link
Copy Markdown
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

总体来说改的不错,但是还是有些小问题,这次改完应该就没问题了。

 Modify the "score":Image send type add base64
适配shamrock,以路径发送图片失败后,使用base64发送图片。
@fumiama fumiama merged commit b8858f0 into FloatTech:master Jan 25, 2024
@vatebur
Copy link
Copy Markdown
Member Author

vatebur commented Jan 25, 2024

感谢指导

@vatebur vatebur deleted the PR_branch branch January 26, 2024 01:41
vatebur added a commit to vatebur/ZeroBot-Plugin that referenced this pull request Jan 26, 2024
…oatTech#853)

Modify the "score":Image send type add base64
适配shamrock,以路径发送图片失败后,使用base64发送图片。
YumeMichi added a commit to YumeMichi/ZeroBot-Plugin that referenced this pull request Jan 29, 2024
* https://github.com/FloatTech/ZeroBot-Plugin:
  Initial Commit for nix (FloatTech#856)
  [issues 840] Modify the "score" of the  Image send type add base64 (FloatTech#853)
  update guessmusic:Reduce the difficulty (FloatTech#854)
  Update pull.yml
  fix: danbooru
  fix chess & kfc && optimize lolicon & bilibili (FloatTech#817)
  fix hyaku & omikuji lazy & score (FloatTech#815)
  🔖 v1.7.6
  fix: hyaku
  🔖 v1.7.5
  🐛 custom lazy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants