-
Notifications
You must be signed in to change notification settings - Fork 124
Description
There is no warning if the receiver name is not parsed from the observation file name. extract_marker_name can return "TEST" and then the antenna options are not used by Ginan.
The marker name / id seems important enough to present in the GUI, and could it refuse to process if it is not parsed to prevent users getting marker offsets wrong and missing the antenna calibration.
Since the GUI supports only one station then could the antenna options simply be placed in the global section to avoid the need for have a matching marker name. Ginan will then process the antenna options presented in the GUI irrespective of the marker name and irrespective of the RINEX file name.
The GUI RINEX extractor does parse the marker name but it does not appear to be used, rather only the file name is used. Might this be because Ginan can not use the marker name from the RINEX file and so it would be pointless for the GUI to use it.
rinex.cpp: decodeObsH() does parse the marker name, but is it used. It also parses the antenna details and can it use these? Or is the GUI having to copy these to the config file because Ginan can not use the RINEX antenna details?
Also only the first four character are being used, but should Ginan be using the extended names now. In some places in RTKLIB the names are now matched giving priority for longer matches, so an extended name can match a short name if there is no better match.
It would appear to be practical for the GUI to also parse the antenna azimuth (and perhaps bore sight) from the RINEX file and to also copy that to the config file - an extension. The antenna azimuth can be useful if the antenna is rotated 180 to cancel out systematic horizontal errors, or if just not set up pointing north.