Add support for ERC-721 (NFT) Tokens #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Nathan Thanks for your PR! Everything looks good! You are correct, only test cases are needed for regression testing of such API. Thats a good question actually, I can't remember like proper strategy I was using at that time, something like "found unused account that barely move assets (probably forgotten) and reinforce tests as mush as possible". I think such strategy is applicable here also, will be waiting test cases for your changes and they will be ready to go! |
|
Looks like rate limit wasn't expecting PR and API key is not propagated and API is rate limited, I'll merge and release it in 1.2.0 |
GoodforGod
approved these changes
Dec 2, 2021
|
Thanks for your contribution @NGuggs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was currently only support for ERC-20 tokens and that Ertherscan used a different endpoint to get ERC-721 (NFT) Tokens.
Changes
I followed the same paradigm used for the ERC-20 tokens and just duplicated and changed for the new endpoint.
Considerations
With how similar the tokens are in requests, the methods could be combined into a single set with an enum or parameter (or similar in function) that determines which token type your are intending and reduces nearly duplicate code. Though it would take extra work to support backwards compatible upgrades to the new version.
Testing
Manually tested against a random account (0x51b1501420C50aDdA1C4942720bC0e7e8C6D768e) which includes both ERC-20 and ERC-721 tokens.
Still need to add test cases for this. But... was curious how you chose the account for the initial set of test cases. I noticed that account did not have ERC-721 tokens and I would be hesitant to use a random account knowing there could be additional tokens in the future and break the tests.
Let me know your throughts.