Changed traceId in TxInternal from long to String #17
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR ! I will make another getter for traceId to retrieve it as String, can't change existing one from long -> string cause this will break API, but I will keep that in mind in 2.0.0 version, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great Java implementation for the etherscan api! While fetching internal transaction data, I ran into a ParseException because of the traceId value of "1_0". In my case it was a refund from a uniswap trade.
You can check it yourself with address 0x82c1174618133b1a320106aa197d0e8ee7e36be4 (random address that interacted with uniswap and has non numeric traceIds for some of its internal transactions.