Skip to content

IDistributedCache implementation and refactoring for cartservice #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 28, 2022
Merged

IDistributedCache implementation and refactoring for cartservice #838

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c402392
better implementation for cartservice
Apr 29, 2022
44de417
Microsoft.Extensions.Caching.StackExchangeRedis
May 24, 2022
8a4ddb6
Merge branch 'main' into mathieu-benoit/fix-cartservice
mathieu-benoit May 25, 2022
a830e07
cleanup
May 25, 2022
1c37b29
Merge branch 'mathieu-benoit/fix-cartservice' of https://github.com/G…
May 25, 2022
28041fc
Grpc.Net.Client 2.46.0
May 25, 2022
2e841d5
Grpc.AspNetCore 2.46.0
May 25, 2022
093865d
Grpc.HealthCheck 2.46.3
May 25, 2022
bad3e18
cleanup
May 25, 2022
402db3e
value.IsNull
May 25, 2022
d76ebb2
value == null
May 25, 2022
00c8874
Merge branch 'main' into mathieu-benoit/fix-cartservice
xtineskim May 27, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
value == null
  • Loading branch information
Mathieu Benoit committed May 25, 2022
commit d76ebb29f03b41677868c3d4be92267ed6c024ac
4 changes: 2 additions & 2 deletions src/cartservice/src/cartstore/RedisCartStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public async Task AddItemAsync(string userId, string productId, int quantity)
{
Hipstershop.Cart cart;
var value = await _cache.GetAsync(userId);
if (value.IsNull)
if (value == null)
{
cart = new Hipstershop.Cart();
cart.UserId = userId;
Expand Down Expand Up @@ -89,7 +89,7 @@ public async Task EmptyCartAsync(string userId)
// Access the cart from the cache
var value = await _cache.GetAsync(userId);

if (!value.IsNull)
if (value != null)
{
return Hipstershop.Cart.Parser.ParseFrom(value);
}
Expand Down