-
Notifications
You must be signed in to change notification settings - Fork 8k
cartservice
- unprivileged container
#848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚲 PR staged at http://34.134.2.241 |
🚲 PR staged at http://34.134.2.241 |
🚲 PR staged at http://34.134.2.241 |
Ready for your review, thanks! Again it's just for The goal here is to have Online Boutique containers/apps running unprivileged (non root, etc.) in order to be easily deployed on secure environment (PSP, Gatekeeper, OpenShift, etc.). Evidence with Bank of Anthos here: GoogleCloudPlatform/bank-of-anthos#517. I will implement this later in there too. Because I already had the implementation of this tested and working on my environment for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for doing this, @mathieu-benoit.
I've tested the staging URL — the cart works fine.
🚲 PR staged at http://34.134.2.241 |
Setup
cartservice
to run as unprivileged container (other services will come later with future dedicated PRs).Deployment
withsecurityContext
featuresDOTNET_EnableDiagnostics=0
in theDockerfile
in order to make thedotnet
app compatible with an unprivleged containerFor added security, you can opt out of the diagnostic pipeline. When you opt-out this allows the container to run as read-only.
Failed to create CoreCLR, HRESULT: 0x80004005