Skip to content

feat: migrate code from googleapis/python-optimization - #8474

Merged
dandhlee merged 27 commits into
mainfrom
python-optimization-migration
Nov 9, 2022
Merged

feat: migrate code from googleapis/python-optimization#8474
dandhlee merged 27 commits into
mainfrom
python-optimization-migration

Conversation

@donmccasland

@donmccasland donmccasland commented Nov 8, 2022

Copy link
Copy Markdown
Member

Description

Migrating samples from googleapis/python-optimization

Checklist

changsongd and others added 23 commits April 6, 2022 17:11
* add code snippets for sync and async api

* remove async test samples

* use f-string

* change project_id to input arg

* add noxfile

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* rename noxfile and add requirements

* rm noxfile

* rm noxfile local

* add root noxfile

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

* Apply suggestions from code review

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add commit to trigger kokoro

* add indentation

* add type annotations

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* Add get_operation code snippets

* update comment

* docs: add sync api samples with json request (#13)

* add code snippets for sync and async api

* remove async test samples

* use f-string

* change project_id to input arg

* add noxfile

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* rename noxfile and add requirements

* rm noxfile

* rm noxfile local

* add root noxfile

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

* Apply suggestions from code review

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* Update noxfile.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add commit to trigger kokoro

* add indentation

* add type annotations

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* rebase and add type annotations

* fix operation_id type

* Update samples/snippets/get_operation.py

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

* Update samples/snippets/get_operation_test.py

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

* move TODO outside func, create operation in test

* lint fix

* fix asyncmodelconfig

* change model_config to list

* add blank line

* change request to dict

* change parent to project id

* remove model config

* Update samples/snippets/get_operation.py

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

* add TODO back

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
* docs: add code snippets for async api

* fix lint and add storage to requirements

* iterator type annotation

* fix typo and test

* remove typing

* add None return type

Co-authored-by: Lo Ferris <50979514+loferris@users.noreply.github.com>
* docs: add long timeout code snippet

* fix lint

* add timeout
* chore: run blacken on all directories with a noxfile

* add missing import

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix imports for prerelease session

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update setup.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@donmccasland
donmccasland requested review from a team as code owners November 8, 2022 22:51
@snippet-bot

snippet-bot Bot commented Nov 8, 2022

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Nov 8, 2022
@donmccasland donmccasland added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@dandhlee dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@dandhlee dandhlee assigned dandhlee and unassigned leahecole Nov 9, 2022

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add CODEOWNERS and blunderbuss for api: cloudoptimization?

@donmccasland donmccasland added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@dandhlee dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 9, 2022

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dandhlee
dandhlee merged commit 8501411 into main Nov 9, 2022
@dandhlee
dandhlee deleted the python-optimization-migration branch November 9, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

6 participants