Skip to content

IECoreUSD::ShaderAlgo : Round-trip ColorSpace data on shader parameters.#1453

Open
boberfly wants to merge 1 commit into
ImageEngine:RB-10.6from
boberfly:feature/usdColorspace
Open

IECoreUSD::ShaderAlgo : Round-trip ColorSpace data on shader parameters.#1453
boberfly wants to merge 1 commit into
ImageEngine:RB-10.6from
boberfly:feature/usdColorspace

Conversation

@boberfly

Copy link
Copy Markdown
Contributor

Generally describe what this PR will do, and why it is needed.

  • Round-trip ColorSpace data on USD attributes, so shaders authored expecting this to work will faithfully translate correctly.

Related Issues

  • While doing IECoreMaterialX work, I noticed ColorSpace on shaders don't round-trip.

Dependencies

  • N/A

Breaking Changes

  • Not sure if it is considered a breaking change, but it does fix up things. Maybe if you are dependent on <paramName>_colorspace parameters existing as real parameters on the USD side, then it'll be problematic but I doubt it would be in-practice. Looking at aiImage they use a dedicated color_space parameter so I doubt it.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

I am using the CI to test this one as I've not got Cortex setup in a proper way yet, thanks! :)

@boberfly boberfly force-pushed the feature/usdColorspace branch 9 times, most recently from 9c4b8e5 to ab4680c Compare February 28, 2025 10:12
@boberfly boberfly force-pushed the feature/usdColorspace branch from ab4680c to 5e2d470 Compare October 6, 2025 20:53
@boberfly boberfly changed the base branch from RB-10.5 to RB-10.6 October 6, 2025 20:54
@boberfly boberfly force-pushed the feature/usdColorspace branch 2 times, most recently from 566ceee to d1f055b Compare October 6, 2025 20:57
@boberfly boberfly force-pushed the feature/usdColorspace branch from d1f055b to 8525464 Compare October 6, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant