Skip to content

Added support for :primary_key in sorting on relationships#1474

Draft
outsmartin wants to merge 1 commit into
JSONAPI-Resources:release-0-9from
outsmartin:patch-1
Draft

Added support for :primary_key in sorting on relationships#1474
outsmartin wants to merge 1 commit into
JSONAPI-Resources:release-0-9from
outsmartin:patch-1

Conversation

@outsmartin

Copy link
Copy Markdown

Fixes ActiveRecord::StatementInvalid (PG::UndefinedFunction: ERROR: operator does not exist: uuid = character varying when uuid and string ids are mixed

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
Fixes ActiveRecord::StatementInvalid (PG::UndefinedFunction: ERROR:  operator does not exist: uuid = character varying when uuid and string ids are mixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant