Fix http_accept header in nginx.conf for docker install#209
Merged
Conversation
e12093d to
7da8867
Compare
Nutomic
approved these changes
Jun 14, 2023
Contributor
|
I think this has to be updated in https://github.com/LemmyNet/lemmy/blob/main/docker/nginx.conf and https://github.com/LemmyNet/lemmy/blob/0.17.4/docker/prod/nginx.conf too? I'm not sure why there's multiple copies of the same Nginx config as it's easy for them to fall out of sync (and indeed the config in the |
Member
|
True it would be good to fix that and consolidate the files in some way. Though the last link is from the release/0.17 branch, so it simply didnt have all the changes backported and wont be relevant once 0.18 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
nginx.confin the english docker install doc has a very stricthttp_acceptheader check. It prevents other services in the Fediverse like Mastodon and Kbin federating with the Lemmy instance due to the way they send thehttp_acceptheader.The change updates the
http_acceptheader check and aligns it with the one in the ansible template.