Skip to content

Upgrades and splitting up some methods - #5

Merged
mielvds merged 9 commits into
LinkedDataFragments:masterfrom
barthanssens:master
Dec 2, 2015
Merged

Upgrades and splitting up some methods#5
mielvds merged 9 commits into
LinkedDataFragments:masterfrom
barthanssens:master

Conversation

@barthanssens

Copy link
Copy Markdown
Contributor

A bunch of suggested changes

  • upgraded Jetty, gson and CLI libraries
  • added serialVersionUID to Exceptions
  • splitted up init() and doGet() methods in TriplePatternFragmentServlet
  • splitted up main() method in the JettyServer
  • used more specific Exceptions
  • explicit imports instead of

Most changes are just a matter of preference, so feel free to ignore them if you think they are not useful :-)

mielvds pushed a commit that referenced this pull request Dec 2, 2015
Upgrades and splitting up some methods
@mielvds
mielvds merged commit 9cfd6cb into LinkedDataFragments:master Dec 2, 2015
@mielvds

mielvds commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

I agree with you preferences :) Merged and part of release 0.0.2

@mielvds

mielvds commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

Pass by val should not really be a problem, but something is

@barthanssens

Copy link
Copy Markdown
Contributor Author

Think it's a merge thing, seems that serialization is done twice in doGet, probably my bad

mielvds pushed a commit that referenced this pull request Jan 4, 2016
merging in latest changes from origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants