Xaml-PasswordPage Modernize - #904
Draft
AndromedaMelody wants to merge 3 commits into
Draft
AndromedaMelody wants to merge 3 commits into
AndromedaMelody wants to merge 3 commits into
Conversation
AndromedaMelody
added
pr-having-implementation-issue
and removed
pr-having-implementation-issue
labels
Member
|
Looks like you can just exclude PasswordDialog.cpp from the NanaZip.UI.Modern project? Then you wouldn't need any changes to the PasswordDialog* files, and that'd make code sync with 7-Zip easier. |
AndromedaMelody
force-pushed
the
dev/pwddlg
branch
from
August 6, 2026 14:17
5cc63ec to
ebb1e6a
Compare
AndromedaMelody
force-pushed
the
dev/pwddlg
branch
2 times, most recently
from
August 6, 2026 15:53
b3affde to
595e49b
Compare
AndromedaMelody
force-pushed
the
dev/pwddlg
branch
from
August 6, 2026 15:55
595e49b to
76ad4f9
Compare
AndromedaMelody
marked this pull request as ready for review
August 6, 2026 16:11
| return E_ABORT; | ||
| } | ||
|
|
||
| Password.SetFrom(PasswordInput, ::lstrlenW(PasswordInput)); |
Member
There was a problem hiding this comment.
Considering that winrt::hstring already gives us the size, should we pass that through K7ModernShowPasswordDialog as well instead of using strlen here?
dongle-the-gadget
requested changes
Aug 11, 2026
| this->OkKeyAcc().ScopeOwner(this->PasswordBoxInput()); | ||
|
|
||
| winrt::hstring WindowTitle = winrt::hstring( | ||
| ::K7ModernGetLegacyStringResource(3800)); |
Member
There was a problem hiding this comment.
We should migrate this resource to modern RESW.
AndromedaMelody
marked this pull request as draft
September 9, 2026 13:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.