Skip to content

Fix #195, Don't log ssl.CertificateError#199

Merged
1st1 merged 1 commit into
MagicStack:masterfrom
fantix:t195_dont_log_ssl_cert_err
Oct 10, 2018
Merged

Fix #195, Don't log ssl.CertificateError#199
1st1 merged 1 commit into
MagicStack:masterfrom
fantix:t195_dont_log_ssl_cert_err

Conversation

@fantix

@fantix fantix commented Sep 29, 2018

Copy link
Copy Markdown
Member
1st1
1st1 reviewed Oct 1, 2018
View reviewed changes
Comment thread uvloop/includes/stdlib.pxi Outdated
cdef int ssl_SSL_ERROR_WANT_WRITE = ssl.SSL_ERROR_WANT_WRITE
cdef int ssl_SSL_ERROR_SYSCALL = ssl.SSL_ERROR_SYSCALL

cdef FATAL_ERROR_IGNORE = (

@1st1 1st1 Oct 1, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to FATAL_SSL_ERROR_IGNORE

@fantix fantix Oct 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Will do, thx.
@1st1

1st1 commented Oct 5, 2018

Copy link
Copy Markdown
Member

What's the status on this?
@fantix fantix force-pushed the t195_dont_log_ssl_cert_err branch from 4477e31 to ad0b9c4 Compare October 5, 2018 09:56
@fantix

fantix commented Oct 5, 2018

Copy link
Copy Markdown
Member Author

There it is! 😃
@1st1 1st1 merged commit 848e478 into MagicStack:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fantix @1st1