add app state check#263
Merged
Merged
Conversation
1st1
reviewed
Aug 23, 2019
1st1
approved these changes
Aug 23, 2019
Member
|
Looks good, thank you! |
j-usti-n
pushed a commit
to j-usti-n/uvloop
that referenced
this pull request
Aug 24, 2019
add app state check (MagicStack#263)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app_statecheck is not added atdata_received()and friends because I think it's too much penalty to raise errors and break connections, even though it should never happen. But please feel free to vote oppositely.