Skip to content

fix(eagleye_coordinate): fix misc-throw-by-value-catch-by-reference#338

Merged
rsasaki0109 merged 1 commit intoMapIV:main-ros1from
team-emb4:clang-39
Nov 8, 2024
Merged

fix(eagleye_coordinate): fix misc-throw-by-value-catch-by-reference#338
rsasaki0109 merged 1 commit intoMapIV:main-ros1from
team-emb4:clang-39

Conversation

@kobayu858
Copy link
Contributor

This is a fix based on clang-tidy misc-throw-by-value-catch-by-reference error.

/home/emb4/autoware/autoware/src/universe/external/eagleye/eagleye_core/coordinate/src/convertheight.cpp:51:10: error: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference,-warnings-as-errors]
  catch (const GeographicLib::GeographicErr err)
         ^
/home/emb4/autoware/autoware/src/universe/external/eagleye/eagleye_core/coordinate/src/convertheight.cpp:67:10: error: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference,-warnings-as-errors]
  catch (const GeographicLib::GeographicErr err)
         ^

I have already confirmed that the build passes with autoware's colcon build.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858
Copy link
Contributor Author

@rsasaki0109
Please excuse my comment as I did not have permission to set up a reviewer.
This is a minor fix baed on clang-tidy.
Please assign another reviewer if there is someone suitable for it, thank you.

@rsasaki0109 rsasaki0109 self-requested a review November 8, 2024 09:54
@rsasaki0109
Copy link
Collaborator

Thank you for the PR. The changes look good, so I'll merge it.

@rsasaki0109 rsasaki0109 merged commit dc67f82 into MapIV:main-ros1 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants