Skip to content

Typos fixed(essential articles added)#904

Closed
mighty-phoenix wants to merge 1 commit into
MariaDB:10.4from
mighty-phoenix:10.4
Closed

Typos fixed(essential articles added)#904
mighty-phoenix wants to merge 1 commit into
MariaDB:10.4from
mighty-phoenix:10.4

Conversation

@mighty-phoenix

Copy link
Copy Markdown
Contributor

Corrected grammar of the documentation.

@an3l

an3l commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

Hi @rakshitkumarcse ,

Thanks for your contribution.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.

The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below, or update your PR comment that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Anel

@iangilfillan can you please review.

@mighty-phoenix

Copy link
Copy Markdown
Contributor Author

I hereby accept and submit this code/PR and other ones in the docs directory under the BSD license

@mighty-phoenix

Copy link
Copy Markdown
Contributor Author

Kindly review and merge it.

@an3l

an3l commented Nov 4, 2018

Copy link
Copy Markdown
Contributor

Hi @rakshitkumarcse ,
can you please rebase this on mariadb-10.1.1 ?
Thanks

@mighty-phoenix

Copy link
Copy Markdown
Contributor Author

@an3l
Kindly see #915
Please merge.

@svoj svoj added this to the 10.4 milestone Nov 26, 2018
svoj pushed a commit that referenced this pull request May 16, 2019
Fix both code paths:
- Change the test source code so it doesn't cause the "Unused variable"
  warning (which -Werror converted into error and caused CMake not to set
  HAVE_THREAD_LOCAL)

- If the system doesn't seem to support HAVE_THREAD_LOCAL, refuse to
  compile (rather than producing a binary that crashes for some tests)

Originally submitted at facebook/mysql-5.6#905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants