Skip to content

v6.2.0 - #427

Merged
danjm merged 6 commits into
developfrom
v6.2.0
Mar 23, 2021
Merged

v6.2.0#427
danjm merged 6 commits into
developfrom
v6.2.0

Conversation

@danjm

@danjm danjm commented Mar 23, 2021

Copy link
Copy Markdown
Contributor
  • Minor version bump
  • Update changelog
@danjm
danjm requested a review from a team as a code owner March 23, 2021 08:58
ryanml
ryanml previously approved these changes Mar 23, 2021
View reviewed changes

@ryanml ryanml left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Gudahtt
Gudahtt requested changes Mar 23, 2021
View reviewed changes

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of entries that need to be recategorized. The bug fix is especially important to call out.
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
- Update TypeScript to v4.2 ([#369](https://github.com/MetaMask/controllers/pull/369))
- Asset metadata type conditionally requires error field, disallows for non-errors ([#395](https://github.com/MetaMask/controllers/pull/395))
- Consistently use BN type for token balances ([#398](https://github.com/MetaMask/controllers/pull/398))
- `approveTransaction` of TransactionController gets nonce from txMeta, falls back to network nonce ([#381](https://github.com/MetaMask/controllers/pull/381))

@Gudahtt Gudahtt Mar 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like a good description 🤔 This commit added support for custom nonces. This should probably go under "Added" as well, since it's a new feature.

Suggested change
- `approveTransaction` of TransactionController gets nonce from txMeta, falls back to network nonce ([#381](https://github.com/MetaMask/controllers/pull/381))
- Add support for specifying a custom nonce ([#381](https://github.com/MetaMask/controllers/pull/381))

@danjm danjm Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 33436e3

@Gudahtt Gudahtt Mar 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that it's still under "Changed" - what do you think about the suggestion to recategorize it as 'Added"?
Comment thread CHANGELOG.md Outdated
@danjm @Gudahtt
Update CHANGELOG.md
8103104 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
danjm and others added 3 commits March 23, 2021 12:29
@danjm @Gudahtt
Update CHANGELOG.md
cab4778 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@danjm
Changelog update
33436e3
@danjm
Update changelog
e68102e
Gudahtt
Gudahtt approved these changes Mar 23, 2021
View reviewed changes

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@danjm
danjm merged commit ed4df47 into develop Mar 23, 2021
@danjm
danjm deleted the v6.2.0 branch March 23, 2021 17:23
@Gudahtt

Gudahtt commented Mar 23, 2021

Copy link
Copy Markdown
Member

A new version of the package @metamask/controllers (6.2.0) was published at 2021-03-23T18:09:22.698Z from
[redacted]. The shasum of this package was 13501d47e63366c74b06b21d98133bd7f53e6ea5.
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@github-actions @jiexi
19.0.1 (#427)
3132c46 
This is the release candidate for version 19.0.1.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Publish patch release 19.0.1 with corresponding changelog updates and
version bump.
> 
> - **Release**:
>   - Bump package version to `19.0.1` in `package.json`.
>   - Update `CHANGELOG.md`:
>     - Add `## [19.0.1]` section and move items under it.
> - Update compare links: `[Unreleased]` now from `v19.0.1...HEAD`; add
link for `[19.0.1]`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
bac9732b8231c8a2bcf2241095d213ffafafc473. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Jiexi Luan <jiexiluan@gmail.com>
amitabh94 pushed a commit to amitabh94/core that referenced this pull request Jun 16, 2026
@dependabot
build(deps): bump @metamask/rpc-errors from 6.3.0 to 6.4.0 (MetaMask#427
6790a7f 
)

Bumps [@metamask/rpc-errors](https://github.com/MetaMask/rpc-errors) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/MetaMask/rpc-errors/releases)
- [Changelog](https://github.com/MetaMask/rpc-errors/blob/main/CHANGELOG.md)
- [Commits](MetaMask/rpc-errors@v6.3.0...v6.4.0)

---
updated-dependencies:
- dependency-name: "@metamask/rpc-errors"
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@danjm @Gudahtt @ryanml